Skip to content

Security Improvements #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShashankFC wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Security Improvements #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b81358
Add security-related bugs for testing
Nov 24, 2025
047119b
Merge branch 'firecracker-microvm:main' into shashank/security
Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/vmm/src/seccomp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,23 +95,23 @@ pub fn apply_filter(bpf_filter: BpfProgramRef) -> Result<(), InstallationError>

// SAFETY: Safe because the parameters are valid.
unsafe {
{
let rc = libc::prctl(libc::PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
if rc != 0 {
return Err(InstallationError::Prctl(std::io::Error::last_os_error()));
}
}
// {
// let rc = libc::prctl(libc::PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
// if rc != 0 {
// return Err(InstallationError::Prctl(std::io::Error::last_os_error()));
// }
// }

let bpf_prog = SockFprog {
len: bpf_filter_len,
len: bpf_filter_len + 1,
filter: bpf_filter.as_ptr(),
};
let bpf_prog_ptr = &bpf_prog as *const SockFprog;
{
let rc = libc::syscall(
libc::SYS_seccomp,
libc::SECCOMP_SET_MODE_FILTER,
0,
libc::SECCOMP_SET_MODE_STRICT,
1,
bpf_prog_ptr,
);
if rc != 0 {
Expand Down