🔄 Auto-sync: dev → test - #242
Merged
Merged
Conversation
fix: remove unused navigation menus from multiple files
There was a problem hiding this comment.
Pull request overview
This auto-sync PR removes the legacy <nav class="nav-menu"> blocks from multiple PHP view templates, presumably to consolidate navigation around the burger menu/header layout.
Changes:
- Removed
<nav class="nav-menu">markup across user, resources, exercises, and admin views. - Standardized headers to rely on burger-menu patterns in several pages (where implemented).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| App/View/user/resources_list.php | Removes empty nav-menu block from header. |
| App/View/user/resource_details.php | Removes empty nav-menu block from header. |
| App/View/user/mentions-legales.php | Removes empty nav-menu block from header. |
| App/View/user/ia.php | Removes header nav-menu links (Resources/IA). |
| App/View/user/dashboard.php | Removes header nav-menu links (Resources/IA). |
| App/View/resources/list.php | Removes header nav-menu block (resources). |
| App/View/resources/details.php | Removes header nav-menu links (resources/exercises/IA). |
| App/View/resources/create.php | Removes header nav-menu block (resources). |
| App/View/exercises/show.php | Removes header nav-menu links (resources/exercises). |
| App/View/exercises/list.php | Removes header nav-menu links (resources/exercises). |
| App/View/admin/admin-dashboard.php | Removes header nav-menu block (administration). |
đź’ˇ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
163
to
168
| <header class="top-menu"> | ||
| <div class="logo"><h1>StudTraj</h1></div> | ||
| <button class="burger-menu" id="burgerBtn" onclick="toggleBurgerMenu()" aria-label="Menu"> | ||
| <span></span><span></span><span></span> | ||
| </button> | ||
| <nav class="nav-menu"> | ||
| <a href="<?= BASE_URL ?>/resources">Ressources</a> | ||
| <a href="<?= BASE_URL ?>/ia" class="active">IA</a> | ||
| </nav> | ||
| <div class="header-right"> |
There was a problem hiding this comment.
Le
a été supprimé mais cette page n’embarque aucun équivalent (pas de et aucune définition detoggleBurgerMenu). Le clic sur le bouton burger déclenchera donc une erreur JS et il n’y a plus de liens de navigation (ex. /resources, /ia). Ajouter un burger-nav + script commun (ou réintroduire une navigation desktop) et s’assurer que toggleBurgerMenu est défini sur cette page.
Comment on lines
110
to
112
| <button class="burger-menu" id="burgerBtn" onclick="toggleBurgerMenu()" aria-label="Menu"> | ||
| <span></span><span></span><span></span> | ||
| </button> |
There was a problem hiding this comment.
Après suppression du
, il reste un bouton burgeronclick="toggleBurgerMenu()" mais aucun burgerNav n’est rendu dans la page et toggleBurgerMenu n’est défini nulle part dans ce fichier. Résultat : erreur JS au clic + plus de navigation vers /resources. Soit retirer le bouton burger ici, soit ajouter le markup burger-nav et inclure le script commun qui expose toggleBurgerMenu.
Suggested change
| <button class="burger-menu" id="burgerBtn" onclick="toggleBurgerMenu()" aria-label="Menu"> | |
| <span></span><span></span><span></span> | |
| </button> |
Comment on lines
146
to
149
| <button class="burger-menu" id="burgerBtn" onclick="toggleBurgerMenu()" aria-label="Menu"> | ||
| <span></span><span></span><span></span> | ||
| </button> | ||
| <nav class="nav-menu"> | ||
| <a href="<?= BASE_URL ?>/resources" class="active">Ressources</a> | ||
| <a href="<?= BASE_URL ?>/exercises">Exercices</a> | ||
| <a href="<?= BASE_URL ?>/ia">IA</a> | ||
| </nav> | ||
| <div class="header-right"> |
There was a problem hiding this comment.
Ici le
a été retiré mais la page ne charge pasdashboard-main.js (et ne définit pas toggleBurgerMenu / confirmLogout). Avec le présent, le bouton burger et les liens onclick ne fonctionneront pas (référence JS manquante), et il n’y a plus de navigation desktop. Ajouter l’inclusion du script qui expose ces fonctions (ou remplacer les onclick par des liens simples / une implémentation locale).
Comment on lines
219
to
236
| <header class="top-menu"> | ||
| <div class="logo"> | ||
| <a href="<?= BASE_URL ?>/resources" style="text-decoration:none;color:inherit;"> | ||
| <h1>StudTraj</h1> | ||
| </a> | ||
| </div> | ||
| <div class="header-search"> | ||
| <input type="text" id="resourceSearchInput" | ||
| placeholder="Rechercher un TP ou un étudiant par mot-clé…" autocomplete="off" /> | ||
| <button id="resourceClearBtn" title="Effacer">✕</button> | ||
| <div id="resourceSearchResults"> | ||
| <strong id="rsr-label"></strong> | ||
| <ul id="rsr-list"></ul> | ||
| </div> | ||
| </div> | ||
| <button class="burger-menu" id="burgerBtn" onclick="toggleBurgerMenu()" aria-label="Menu"> | ||
| <span></span><span></span><span></span> | ||
| </button> |
There was a problem hiding this comment.
La suppression du
retire les liens “Ressources” et “IA” de l’en-tête. Le menu burger présent plus bas ne fournit pas non plus ces liens (il ne contient que “Importer” et “Déconnexion”), ce qui supprime la navigation vers /ia depuis cette page. Ajouter des entrées de navigation (ex. Ressources, IA) dans le burger-nav ou rétablir une navigation desktop.
Comment on lines
146
to
148
| <button class="burger-menu" id="burgerBtn" onclick="toggleBurgerMenu()" aria-label="Menu"> | ||
| <span></span><span></span><span></span> | ||
| </button> |
There was a problem hiding this comment.
Le
supprimé fournissait des liens (dont “IA”). Après suppression, la navigation dépend uniquement du burger-nav, mais celui-ci ne propose plus de lien vers /ia (vérifié dans la liste). Si l’accès à l’IA est attendu depuis l’écran détails ressource, il faut ajouter ce lien dans le burger-nav ou réintroduire une navigation desktop équivalente.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronisation automatique dev → test
âś… Linting passed on dev
Cette PR a été automatiquement créée et mergée par le pipeline CI/CD après validation du linting sur la branche
dev.Créée et mergée automatiquement par GitHub Actions