Skip to content

public boolean isNegative() change #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StreignardM wants to merge 2 commits into
base: test
Choose a base branch
from
Open

public boolean isNegative() change #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
893668f
isNegative() change
StreignardM Oct 25, 2019
f4c3db2
Update Fraction.java
StreignardM Nov 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/tp/Fraction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ public boolean isInteger() {
* @return true if the current fraction is strictly less than 0
*/
public boolean isNegative() {
return false;
double result = numerator/denominator;
return (denominator == 0 || result < 0)? true:false;

@vvandenschrieck vvandenschrieck Nov 8, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heu, je ne comprends pas la logique... ???

@vvandenschrieck vvandenschrieck Nov 15, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autre commentaire : double result = numerator/denominator risque toujours d'avoir des problèmes d'arrondi. Les opérandes de la divisions sont des entiers, donc le quotient sera un entier. Stocker ce résultat dans un double ne changera rien, on aura perdu de l'information. Tu dois "caster" les opérandes en double avant la division (une des deux suffit normalement).

}

/**
Expand Down