Update method multiply#10
Open
jeanmtang wants to merge 2 commits into
Open
Conversation
Update the multiply method
vvandenschrieck
requested changes
Nov 9, 2019
| return denominator; | ||
| } | ||
| /** LEBAS Yaël | ||
| /** LEBAS Yaël |
Collaborator
There was a problem hiding this comment.
Ne concerne pas ta méthode, sors cette modification de ton commit
Comment on lines
122
to
125
| public Fraction multiply(Fraction f) { | ||
| this.numerator *= f.getNumerator(); | ||
| this.denominator *= f.getDenominator(); | ||
| return null; |
Collaborator
There was a problem hiding this comment.
Lis bien la spécification :
- La méthode ne modifie pas la fraction courante, mais renvoie une nouvelle fraction qui est le produit des deux opérandes (ici, tu renvoies null)
- La fraction résultant du calcul doit être simplifiée
Changed the logic of the function multiply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the multiply method