Skip to content

1.0.7: BOT_SELF_CHECK is swallowed by the BOT_PARALLEL comment and never written #1

Description

@0xKr4kN

In 1.0.7 (793f6ea), the new BOT_PARALLEL entry in write_env() does not close
its line, so the BOT_SELF_CHECK entry that followed it is now part of its
trailing comment:

f"BOT_PARALLEL={st.get('options', {}).get('parallel') or (1 if cap <= 60 else 2 if cap <= 150 else 4)}",   # générations simultanées : moins = machine plus fraîche f"BOT_SELF_CHECK={'1' if tier in ('A', 'B') else '0'}",

BOT_SELF_CHECK is therefore never written to engine/.env, and
engine/kibble-bot.py:286 falls back to its own default:

if why == "ollama" and len(out) >= 300 and env.get("BOT_SELF_CHECK", "1") == "1":

So the self-check pass now runs on tiers C and D, where app.py intends 0
the inverse of the intent, and on exactly the machines the setting exists for.
It costs a second generation per delivery on the small models that
kibble-bot.py's own comment says rewrite their answer anyway.

Reproduce: run 1.0.7 on a tier C or D machine, then look at engine/.env
there is no BOT_SELF_CHECK line. Before 1.0.7 it read BOT_SELF_CHECK=0.

Fix: put it back on its own line.

f"BOT_PARALLEL={...}",   # générations simultanées : moins = machine plus fraîche
f"BOT_SELF_CHECK={'1' if tier in ('A', 'B') else '0'}",

Found on a tier D machine running 1.0.7 in a container: the line reads fine in
the source, only the missing variable in the generated .env gives it away.

Thanks for 1.0.7 — the temperature pause is the right shape for the problem. One
note from the container side: it reads gpu_temp, so on a machine with no
nvidia-smi the limit is settable but can never fire. A word in the UI when no
temperature is readable would save someone assuming they are protected.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions