ci: qualify the scaffold_update call ahead of the kit's export-to-public move#246
Open
seabbs-bot wants to merge 1 commit into
Open
ci: qualify the scaffold_update call ahead of the kit's export-to-public move#246seabbs-bot wants to merge 1 commit into
seabbs-bot wants to merge 1 commit into
Conversation
…lic move EpiAwarePackageTools is moving scaffold_update from exported to public (kit#294/#295, being renamed to update with a transitional alias), so the unqualified call here would break on the next scheduled sync (the kit is installed at rev = main, unpinned). The qualified call works with the current kit and with the renamed one via its alias, so this merges safely in any order relative to the kit change. Approved for cross-repo rollout by @seabbs. Co-authored-by: Sam Abbott <contact@samabbott.co.uk>
Contributor
Try this Pull Request!Option 1: Julia Package ManagerOpen Julia and type: import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/EpiAware/ComposedDistributions.jl", rev="chore/kit294-qualify-scaffold-update")
using ComposedDistributionsOption 2: Local CheckoutIf you have the repo locally: git checkout chore/kit294-qualify-scaffold-update
julia --project=. -e "using Pkg; Pkg.instantiate()" |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
📖 Documentation preview is ready! View the docs for this PR at: https://EpiAware.github.io/ComposedDistributions.jl/previews/PR246/ This preview will be updated automatically when you push new commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fix approved by @seabbs for cross-repo rollout: template-sync.yaml's unqualified
scaffold_update(...)call becomesEpiAwarePackageTools.scaffold_update(...). The kit is moving the function from exported to public (kit#294/#295, with a rename toupdateplus a transitional alias), and this workflow installs the kit unpinned at rev=main — without this fix the next scheduled sync after the kit change fails, and cannot self-heal (the broken file is the one sync would fix). The qualified call works with the current kit and the renamed one, so this merges safely in any order.This was opened by a bot. Please ping @seabbs for any questions.
checks-passed