linker: keep dotted export names from becoming forwarders - #897
Closed
honkstar1 wants to merge 4 commits into
Closed
linker: keep dotted export names from becoming forwarders#897honkstar1 wants to merge 4 commits into
honkstar1 wants to merge 4 commits into
Conversation
* show referenced by function * show inline site that references unresolved symbol instead of the top function
Author
|
Closing as implemented upstream by 1091801. The upstream alias/nonempty condition distinguishes an actual forwarder from a plain dotted export name, so the production fix in this PR no longer needs to be carried. The refreshed #842 retains a declarative regression covering both a plain AutoRTFM dotted export and a real name=module.symbol forwarder. Both pass in the refreshed suite. #892 no longer carries a duplicate dotted-export fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/EXPORT:names: onlyexport=module.symbolis a forwarder.__RTFM.autortfm_is_context_statusas normal exports.Validation
D:\devel\git\raddebugger\build\radlink.exewith MSVC 14.50 release flags..rspfiles and checkeddumpbin /exports:__RTFM.autortfm_is_context_status.__RTFM.?...dotted exports instead of an unnamed forwarder.