warnings: Remove ContextMessageReference when context message is deleted - #362
Merged
Merged
Conversation
Erisa
approved these changes
Jul 5, 2026
github-project-automation
Bot
moved this from Approved, awaiting merge
to Done
in Cliptok todo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take 2: Fixes #359
If the context message for a warning is deleted (regular delete or bulk delete), the warning's
ContextMessageReferenceis set to null to prevent errors if the warning is later edited or deletedShould no longer throw NREs when uncached messages are deleted.