Skip to content

feat(useaccountmanager): add ability to input callback functions #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
brandonlammey wants to merge 39 commits into
base: develop
Choose a base branch
from
Draft

feat(useaccountmanager): add ability to input callback functions #472

brandonlammey wants to merge 39 commits into from

Conversation

@brandonlammey
Copy link
Contributor

@brandonlammey brandonlammey commented May 24, 2021 •
edited
Loading

Description

  • Add state to track login popup
  • Add callback function params

Related Issue

Closes #465

Motivation and Context

  • Allows the user to track when the login popup is open to control a loader
  • Allows input of callback functions to easily fire off events when accountManager state is updated

How Has This Been Tested?

Tested in docz

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@brandonlammey brandonlammey self-assigned this May 24, 2021
@brandonlammey
Copy link
Contributor Author

brandonlammey commented May 25, 2021 •
edited
Loading

  • callbacks added for: addAccount, removeAccount, logoutAccount
  • callbacks added for: removeAllAccounts, logoutAllAccounts, restoreAccount, refreshAccount
  • popupOpen added to accountManagerState
    • set for addAccount
    • set for refresh/restore
    • check if closed when user closes window directly

@brandonlammey
test(useaccountmanager): testing function
31810ea
@brandonlammey
test(useaccountmanager): testing function
519bec3
@brandonlammey
test(useaccountmanager): testing function
36d880f
@brandonlammey
test(useaccountmanager): testing function
c8e6d25
@brandonlammey
test(useaccountmanager): testing function
40c6f6b
@brandonlammey
test(useaccountmanager): testing function
887230a
@brandonlammey
test(useaccountmanager): testing function
580ef3d
@brandonlammey
test(useaccountmanager): testing function
00de813
@brandonlammey
test(useaccountmanager): testing function
ca4cc96
@brandonlammey
test(useaccountmanager): testing function
24eea56
@brandonlammey
test(useaccountmanager): testing function
c8d07b6
@brandonlammey
test(useaccountmanager): testing function
0acf130
@brandonlammey
test(useaccountmanager): testing function
264169d
@brandonlammey
test(useaccountmanager): testing function
78e624b
@brandonlammey
test(useaccountmanager): testing function
4aabf24
@brandonlammey
test(useaccountmanager): testing function
3dbca83
@brandonlammey
test(useaccountmanager): testing function
de37e98
@brandonlammey
test(useaccountmanager): testing function
7ee7e39
@brandonlammey
test(useaccountmanager): testing function
af853ce
@brandonlammey
test(useaccountmanager): testing function
957ff4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brandonlammey brandonlammey

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

useAccountManager popup improvements

2 participants

@brandonlammey