fix(cert-manager-config): make the Cloudflare ExternalSecret key configurable - #52
Merged
Merged
Conversation
…igurable `cluster-issuer-cloudflare.yaml` already had a secret-store branch, but its `remoteRef.key` was hardcoded to `cloudflare-api-token` — a flat Azure Key Vault name. On AWS the external-secrets IRSA role is scoped to `estabilis/<deploymentId>/*`, so a bare key never resolves. The effect was that the branch was unusable on AWS, leaving those deployments on the direct-injection path, which writes the token in cleartext onto the Application spec — an ArgoCD Application is a CRD, so it sits outside the EKS `resources: ["secrets"]` envelope encryption, and it is readable in the ArgoCD UI/API and the repo-server cache. The key now reads from `kvSecrets.cloudflareApiToken`, defaulting to the previous literal so Azure renders byte-identically. platform-root passes the prefixed Secrets Manager path on AWS (companion PR in estabilis-platform). Rendered: default -> "cloudflare-api-token"; with kvSecrets -> the full path; with a direct token -> no ExternalSecret, direct path still wins. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VefhWrLXRQq6sEVgTTuXk5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cluster-issuer-cloudflare.yamlalready had a secret-store branch — but itsremoteRef.keywas hardcoded:That is a flat Azure Key Vault name. On AWS the external-secrets IRSA role is scoped to
estabilis/<deploymentId>/*, so a bare key never resolves.Net effect: the branch was unusable on AWS, leaving those deployments on the direct-injection path — which writes the token in cleartext onto the Application spec. An ArgoCD Application is a CRD, so it sits outside the EKS
resources: ["secrets"]envelope encryption, and it is readable in the ArgoCD UI/API and the repo-server cache.Change
remoteRef.keynow readskvSecrets.cloudflareApiToken, defaulting to the previous literal.platform-rootpasses the prefixed Secrets Manager path on AWS — companion PR Estabilis/estabilis-platform#200.Verified by rendering
remoteRef.key"cloudflare-api-token"— unchangedkvSecrets.cloudflareApiToken=estabilis/demo/platform-cloudflare-api-tokenglobal.cloudflareApiTokensetCHANGELOG entry added under
[Unreleased]; no version bump here, per CONTRIBUTING the release moves it and bumpsworkload-bootstrap/in its own commit.🤖 Generated with Claude Code