docs: release process must match what the workflow actually matches - #54
Merged
Merged
Conversation
CONTRIBUTING said to commit "release: vX.Y.Z" and tag by hand. The workflow matches "chore(release): vX.Y.Z" and does the tagging itself, so following the document produced a tag with no GitHub Release and no error anywhere — which is exactly what happened on v0.44.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O
CONTRIBUTINGmandava commitarrelease: vX.Y.Ze taggear à mão. O.github/workflows/release.yamlcasachore(release): vX.Y.Ze faz a tag sozinho.Seguir o documento produz tag sem GitHub Release, e nenhum erro em lugar nenhum — o workflow roda, não casa nada e sai verde. Foi o que aconteceu no v0.44.0 (Release publicada manualmente depois).
Corrige o procedimento e documenta os dois modos de falha silenciosa: subject diferente, e squash merge (que reescreve para
chore(release): vX.Y.Z (#NNN)e não casa a regex ancorada).