Update backends.py by FBrosset · Pull Request #1259 · EsupPortail/Esup-Pod

FBrosset · 2025-02-03T08:11:04Z

Affectation automatique des utilisateurs dans un accessgroup pour une authentification OIDC

Before sending your pull request, make sure the following are done

You have read our contribution guidelines.
Your PR targets the develop branch.
The title of your PR starts with [WIP] or [DONE].

* Upgrade securtity dependances * Remove deprecated django-tagging * Add new django-tagulous * Elasticsearch default version is Now 8 (remove compatibility with ES 6) * Replace deprecated ugettext_lazy by gettext_lazy * Add some temporary deprecations Hacks for cas-client & Chunked-upload * Replace deprecated url() by re_path() * Disable all Pods apps by default * Correct error handling for ElasticSearch

# Conflicts: # pod/settings.py

* Replace some re_path() by path() * Replace remaining ugettext by gettext * Replace admin.site.register() call by @admin.register decorator * Replace HTTP_X_REQUESTED_WITH by `headers={"x-requested-with"` * Replace request.META by headers * Replace `assertQuerysetEqual` by `assertQuerySetEqual` * Replace force_text by force_str * Remove default_app_config in __init__.py

…select2 CSS calls) * Correct Enrichment form validation process

* Replace Django 3.2 by 4.2 in all links

# Conflicts: # pod/settings.py

…ated

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Disable Shib Middleware tests as it seems deprecated

+ remove some ES deprecations

Badatos

Bonjour Fred, Merci pour cette PR ;)
Est-ce que tu peux ajouter une explication dans le configuration.json sur nouveau paramètre OIDC_CLAIM_AFFILIATIONstp ?

Badatos · 2025-02-03T08:19:45Z

... et au passage, si tu peux ajouter un test unitaire qui s'assure que ce parametre fait bien son job stp ?

Ajout du paramètre OIDC_CLAIM_AFFILIATION permettant de récupérer les affiliations

Ajout du paramètre OIDC_CLAIM_AFFILIATION pour récupérer les affiliations

Ajout du paramètre OIDC_CLAIM_AFFILIATION

FBrosset · 2025-02-03T10:23:02Z

Désolé mais c'est bon j'ai modifié le fichier configuration.json.
Par contre explique-moi où sont et comment faire les tests unitaires s'il te plaît

Badatos · 2025-02-03T13:18:21Z

Désolé mais c'est bon j'ai modifié le fichier configuration.json. Par contre explique-moi où sont et comment faire les tests unitaires s'il te plaît

Merci ;)

Pour les tests, ca se passe dans le dossier "tests" de l'appli à tester.
En l'occurence, pod/authentication/tests

Pour l'OIDC, je dirais qu'il faut ajouter une fonction dans la classe "PopulatedOIDCTestCase" de test_populated.py

Ajout test test_OIDC_user_with_multiple_claim_access_groups pour tester l'affectation multiple d'un utilisateur à des accessgroup contenu dans un "claim" OIDC

Badatos · 2025-02-04T08:15:45Z

-        OIDC_OP_USER_ENDPOINT="https://auth.server.com/oauth/userinfo",
-        OIDC_DEFAULT_ACCESS_GROUP_CODE_NAMES=["specific"],
-    )
    def test_OIDC_user_with_default_access_group(self) -> None:


Attention, ici tu as perdu l'info OIDC_DEFAULT_ACCESS_GROUP_CODE_NAMES=["specific"] c'est voulu ?

Refactorisation du code suite aux remarques de flake8

…FILIATION

Badatos · 2025-02-05T11:29:26Z

Hello Fred !
J'ai poussé une modif qui corrige les tests unitaires pour que ca passe.
J'ai du ajouter la vérification que désormais l'utilisateur a bien été assigné à un groupe "OIDC_DEFAULT_AFFILIATION".
(Ce qui n'était visiblement pas le cas avant)
Si ce n'est pas voulu, il faudra changer ce comportement dans le backend.

# Conflicts: # .github/workflows/pod_dev.yml # pod/authentication/tests/test_populated.py # pod/authentication/tests/test_views.py # pod/authentication/urls.py # pod/authentication/views.py # pod/settings.py # pod/urls.py # requirements.txt

Badatos · 2025-03-13T10:01:02Z

@FBrosset , si tu passes par là, peux-tu jeter un œil à cette PR stp ?

FBrosset · 2025-03-18T08:47:05Z

Salut Olivier
Je reviens sur le projet, j'ai été pas mal occupé ailleurs. Je regarde ce que tu as fait.

Badatos and others added 30 commits October 24, 2024 12:10

Merge branch 'develop' into pod_V4

e50187e

# Conflicts: # pod/settings.py

Remove USE_L10N from test_settings

af15471

Merge branch 'develop' into pod_V4

7c01d4b

* Correct video_edit slect2 display with tagulous (remove duplicated …

a721a03

…select2 CSS calls) * Correct Enrichment form validation process

* Remove Python 3.8 from compatible py versions, and add 3.12

4deb722

* Replace Django 3.2 by 4.2 in all links

Merge branch 'develop' into pod_V4

b2975a6

# Conflicts: # pod/settings.py

Upgrade dependencies

645b930

several corrections for 4.0. Prepare to say goodbye to CKEditor

7c5d362

correct video/models.py

917a006

Remove Compatibility with ES 6

9a4ab7f

Replace js_asset by django.templatetags.static, as js_asset is deprec…

097edab

…ated

Fix code scanning alert no. 81: URL redirection from remote source

151af7c

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Improve security in pod playlists, as suggested by CodeQL

ccfebc3

Disable some video_tags functions

5941015

Flake8 compliance

bf7dc21

Disable Debug in test_settings

cb32056

only add debug toolbar when not in testing mode

c9de8e1

Add title_en to sample videos.json

d28b3dc

Reset ES-INDEX for tests as "Pod"

6bd0164

Use Elasticsearch 7 in github workflows

3c17c09

set Video tags as "not required" + correct bug on video tags indexing

b54952b

Adapt Video views and video-info to Tagulous

fd9fbaa

adapt video get_json_to_index() function to Tagulous

bf5cabd

Adapt Video Recorder to Tagulous

92ac5b2

Only do dressing tests when `USE_DRESSING==True

cecec76

* Only run cut tests when USE_CUT==True

f7d1a21

* Disable Shib Middleware tests as it seems deprecated

Merge branch 'develop' into pod_V4

44a9a5b

+ Upgrade all py packages

dfd0662

+ remove some ES deprecations

Badatos requested changes Feb 3, 2025

View reviewed changes

FBrosset added 2 commits February 3, 2025 09:36

Update CONFIGURATION_FR.md

3c0a15b

Ajout du paramètre OIDC_CLAIM_AFFILIATION permettant de récupérer les affiliations

Update CONFIGURATION_EN.md

ab86186

Ajout du paramètre OIDC_CLAIM_AFFILIATION pour récupérer les affiliations

Badatos reviewed Feb 3, 2025

View reviewed changes

Comment thread CONFIGURATION_FR.md

Update configuration.json

1c16298

Ajout du paramètre OIDC_CLAIM_AFFILIATION

Badatos reviewed Feb 3, 2025

View reviewed changes

Comment thread pod/main/configuration.json Outdated

Badatos assigned FBrosset Feb 3, 2025

Update test_populated.py

17fce3f

Ajout test test_OIDC_user_with_multiple_claim_access_groups pour tester l'affectation multiple d'un utilisateur à des accessgroup contenu dans un "claim" OIDC

Badatos requested changes Feb 4, 2025

View reviewed changes

FBrosset and others added 4 commits February 4, 2025 15:07

Update backends.py

e2df422

Refactorisation du code suite aux remarques de flake8

Update test_populated.py

79bd664

correct some bugs after unit testing with @FBrosset

10fa81b

Correct test_populated to test presence of group from OIDC_DEFAULT_AF…

e62bb86

…FILIATION

Badatos added 5 commits February 6, 2025 16:49

Add english translations for configs

a7bac5b

Merge branch 'main' into replace_cas

ebcc0d2

# Conflicts: # .github/workflows/pod_dev.yml # pod/authentication/tests/test_populated.py # pod/authentication/tests/test_views.py # pod/authentication/urls.py # pod/authentication/views.py # pod/settings.py # pod/urls.py # requirements.txt

Cleanup merge artifacts

2d6f6b0

Merge branch 'main' into replace_cas

3a014b9

Merge branch 'replace_cas' into replace_cas_fbrosset

4df1dd2

Base automatically changed from replace_cas to main April 8, 2025 13:51

Badatos marked this pull request as draft April 23, 2025 12:16

Badatos changed the base branch from main to dev_v4 July 21, 2025 08:37

Badatos added this to the 4.x milestone Sep 12, 2025

Base automatically changed from dev_v4 to main November 10, 2025 11:03

Badatos changed the base branch from main to dev_v4 November 12, 2025 08:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update backends.py#1259

Update backends.py#1259
FBrosset wants to merge 79 commits intodev_v4from
replace_cas_fbrosset

FBrosset commented Feb 3, 2025

Uh oh!

Badatos left a comment

Uh oh!

Badatos commented Feb 3, 2025

Uh oh!

Uh oh!

FBrosset commented Feb 3, 2025

Uh oh!

Uh oh!

Badatos commented Feb 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Badatos Feb 4, 2025

Uh oh!

Uh oh!

Uh oh!

Badatos commented Feb 5, 2025

Uh oh!

Badatos commented Mar 13, 2025

Uh oh!

FBrosset commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

FBrosset commented Feb 3, 2025

Before sending your pull request, make sure the following are done

Uh oh!

Badatos left a comment

Choose a reason for hiding this comment

Uh oh!

Badatos commented Feb 3, 2025

Uh oh!

Uh oh!

FBrosset commented Feb 3, 2025

Uh oh!

Uh oh!

Badatos commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Badatos Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Badatos commented Feb 5, 2025

Uh oh!

Badatos commented Mar 13, 2025

Uh oh!

FBrosset commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Badatos commented Feb 3, 2025 •

edited

Loading