fix: accept OpenAI tool results without optional name - #2
Open
thorethy1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OpenAI-compatible clients may send a tool-result message with
role: "tool",tool_call_id, andcontentbut withoutname.nameis optional in the OpenAI message schema, yet the Python and RustMessagevalidators required it and rejected an otherwise valid tool-result follow-up.Fix
tool_call_idfor tool messages, but allownameto remain omitted in Python.tool_call_id./v1/chat/completionsHTTP boundaries.Validation
516 passed; MyPy reports no issues in 10 source files.261 passed.cargo fmt --check;254 passed.upstream/mainboth report the same 22 pre-existing findings; this change introduces 0 new findings.git diff --checkpasses.Checklist
tool_call_idremains mandatory.namebehavior is consistent across Python, TypeScript, and Rust.nameis covered.