fix: 🐛 Fix operator precedence in About customer URL href#57
Draft
wapec wants to merge 1 commit intoEuro-Office:mainfrom
Draft
fix: 🐛 Fix operator precedence in About customer URL href#57wapec wants to merge 1 commit intoEuro-Office:mainfrom
wapec wants to merge 1 commit intoEuro-Office:mainfrom
Conversation
The ternary and string concatenation were not grouped correctly — due to operator precedence, the expression evaluated as: condition ? 'http://' : urlCustomer instead of: (condition ? 'http://' : '') + urlCustomer When urlCustomer had no scheme, href became 'http://' with the actual URL silently dropped. Affects all white-labelled installations supplying customization.customer.www without a protocol prefix. Signed-off-by: Bohdan Baranov <wapec@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ternary and string concatenation were not grouped correctly — due to operator precedence, the expression evaluated as:
condition ? 'http://' : urlCustomer
instead of:
(condition ? 'http://' : '') + urlCustomer
When urlCustomer had no scheme, href became 'http://' with the actual URL silently dropped. Affects all white-labelled installations supplying customization.customer.www without a protocol prefix.