fix: replace remaining == None with is None, bare except with except Exception#137
Open
Jah-yee wants to merge 1 commit intoEverMind-AI:mainfrom
Open
fix: replace remaining == None with is None, bare except with except Exception#137Jah-yee wants to merge 1 commit intoEverMind-AI:mainfrom
Jah-yee wants to merge 1 commit intoEverMind-AI:mainfrom
Conversation
…Exception - mem_memorize.py: 3 instances of == None → is None - mem_db_operations.py: bare except → except Exception - episodic_memory_milvus_repository.py: bare except → except Exception Follows Python best practices (PEP 8) for None comparisons and exception handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
I found and fixed the remaining Python anti-patterns in the codebase that were not addressed in previous PRs.
Changes
1. Replace == None with is None (3 instances)
src/biz_layer/mem_memorize.py(lines 1293, 1329, 1348)is Noneoris not Noneinstead of== Noneor!= None2. Replace bare except with except Exception (2 instances)
src/biz_layer/mem_db_operations.py(line 146)src/infra_layer/adapters/out/search/repository/episodic_memory_milvus_repository.py(line 127)Testing
python3 -m py_compile)Related Issues
感谢你们的奉献，希望能提供帮助。如果我解决得有问题或有待商妥的地方，请在下面留言，我会来处理。
Warmly,
Spark Lab Scout