fix(search): scope deprecated_by filter to user tables only#330
Merged
Conversation
compile_filters() unconditionally appended 'deprecated_by IS NULL' to every query, but the deprecated_by column only exists on user-scoped tables (episode, atomic_fact — Reflection V1). Agent tables (agent_case, agent_skill) lack this column, causing a SQL error on agent search/get queries. Gate the clause behind owner_type == 'user' so agent queries no longer reference a non-existent column. Bump version to 1.1.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compile_filters()unconditionally appendeddeprecated_by IS NULLto every LanceDB query, but thedeprecated_bycolumn only exists on user-scoped tables (episode, atomic_fact — Reflection V1). Agent tables (agent_case, agent_skill) lack this column, causing a SQL error on agent search/get queries.Fix: gate the clause behind
owner_type == "user"so agent queries no longer reference a non-existent column.Also bumps version to 1.1.2.
Area
Verification
Checklist
main..envfiles, dependency folders, or generated output.Notes for Reviewers
exclude_deprecatedparameter was already removed from the public API in v1.1.1 (15efd11), but the unconditionaldeprecated_by IS NULLclause remained incompile_filters(). This PR completes that cleanup.docs/openapi.jsonregenerated viamake openapito match the 1.1.2 version bump.By submitting this pull request, I agree that my contribution is licensed under
the Apache License 2.0.