fix(install): merge config instead of overwriting on opencode target#239
Merged
kieranklaassen merged 1 commit intoEveryInc:mainfrom Mar 10, 2026
Merged
Conversation
The sync path's mergeJsonConfigAtKey had incoming entries overwriting existing user entries on conflict. Reverse the spread order so user config wins, matching the install path's existing behavior. Also add merge feedback logging and a test for the sync merge path. Fixes EveryInc#125 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #125
The sync path's
mergeJsonConfigAtKeyhad incoming plugin entries overwriting existing user entries when names conflicted. This reversed the spread order so user config always wins on conflict, matching the install path's existing merge behavior. Also adds user-facing log feedback when config is merged and a test for the sync merge path.Changes
src/sync/json-config.tsso existing user entries take precedence over incoming plugin entriessrc/targets/opencode.tsso users see their config was preservedTesting
bun test tests/opencode-writer.test.ts- all 9 tests passmergeJsonConfigAtKey > preserves existing user entries on conflictverifies user config winsThis contribution was developed with AI assistance (Claude Code).