[pull] master from beyond-all-reason:master - #240
Merged
Merged
Conversation
Nerfed bp aircons, which were changed last month. Made mobile jammers stats more consistent, some were just obviously better than others for no reason. Now the logic is that vehicles are faster, bots are cheaper. Arm is little faster, but costs little more. Includes updated changelog for this + lasers + script improvements of the past weeks
Small units getting submerged in shallow water, and therefore becoming invulnerable to non-AoE weapons (ie Lasers) is currently a problem. Normal units can go to -20 deep water, while a few of them (vehicle scouts, minelayers, light tanks, amphib tanks, t1 arty) have hitboxes less tall than that. So a solution (not the only solution, but probably the simplest) to fix that is giving lasers a tiny AoE, and resizing some hitboxes by 1-2 elmos. The AoE added to Lasers doesn't matter much for ground combat - lasers typically hit the unit they're targeting right in the middle, and the AoE is smaller than the radius of any unit -> you won't ever hit multiple units with single attack except in fringe cases like shooting at radar dots, or a long beamtime weapon like Pulsar easier hitting multiple units. A notable change is that Lasers will then deal damage to stacked air units. But this should be fine too, as all other weapons already do so.
Adds a bindable action per keybind profile, so a key can make a specific profile active. The binding names its profile, so the name is an id in the keymaps and not only in the store. That is why a rename rewrites uikeys.txt as well as the profiles: leave it stale and the next launch finds a keymap matching no profile and keeps it as a new one. AI disclosure: written with assistance from Claude Code.
Carries a changed keybind profile onto the player keymap instead of forking their old one into a copy. A shipped profile moved by a game update, or a store edited by an external tool between sessions, previously reached nobody who had already launched once. Existing stores hold no record of what was last written, so the launch that upgrades them still falls back to the old whole-keymap match, which cannot tell a profile that changed from a file the player edited. That means this wants to land before any release that changes a shipped profile, or those players fork once more on the way through. AI disclosure: written with assistance from Claude Code.
A pass over the keybind editor, cleaning up what testing and review turned up. - placeholder text showing as an action description - revert hint on the whole row rather than the default chip - a key's actions listed out of the order the engine tries them - keychains listed among what a single press fires (these still show, but aren't in the middle of the list, on the keyboard view) - clicking a key on the keyboard left you in a hidden filter (UX on this was preserved by using functionality that Floris had already built into the regular "search" box) - Any+ bindings missing from a search naming modifiers - the list not scrolling back to the top when narrowed - a search outliving the panel it was typed in - the selected profile styling breaking up the dropdown AI disclosure: written with assistance from Claude Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )