fix(core): exclude .stryker-tmp from vitest test discovery - #102
Merged
Merged
Conversation
vitest's default test-file glob picked up Playwright's own e2e suite inside Stryker's instrumented sandbox copies under .stryker-tmp/ sandbox-*/, since the existing e2e exclude pattern only matches the real src/ path, not this prefixed one. Running pnpm test (e.g. via the pre-push hook) while a mutation run's sandbox exists on disk therefore failed on test.describe() being called outside a Playwright config. Matches the same exclusion eslint.config.ts and stryker. config.ts's own ignorePatterns already carry.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.21.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two parallel mutation-testing fix-up runs both hit `pnpm test` failing via the pre-push hook while their own Stryker sandbox (`.stryker-tmp/sandbox-*/`) existed on disk in the same worktree -- vitest's default discovery glob picked up the sandbox's own nested copy of Playwright's e2e suite, since the existing `src/bridges/user/web/e2e/` exclude only matches the real path, not the `.stryker-tmp`-prefixed one. Adds `.stryker-tmp/` to vitest's exclude list, matching the identical exclusion eslint.config.ts and stryker.config.ts already carry for the same reason.