test(core): wire-mesh-transport.ts accepting-side disconnect and dial dedup coverage - #115
Merged
Merged
Conversation
…anup Adds: - the accepting side of a connectToPeer session (the side that ran handleAcceptedConnection, not the dialling side) fires its own onPeerDisconnected when the peer it accepted from disconnects -- distinct from, and previously only proven via, the dialling side's own symmetric watchForDisconnect wiring - a peer that disconnects is cleared out of the dial-dedup set (dataDials), so connectToPeer for the same peer id genuinely re-dials afterwards rather than being silently treated as already-connected and skipped
Mearman
marked this pull request as ready for review
September 14, 2026 08:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.21.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #101 (which merged the first two batches of agent-comms#64's wire-mesh-transport.ts slice into main). #101's own branch was deleted on merge while this third batch was still in progress, so it lands here as its own PR based on current main.
Adds two more direct WireMeshTransport regression tests:
Test plan
pnpm typecheck && pnpm lint && pnpm testgreen locally