test(core): direct unit tests for AgentRegistry's identity/registration/lifecycle behaviour - #121
Merged
Merged
Conversation
…lifecycle directly AgentRegistry was previously exercised only indirectly through MeshStore and room-kick-revocation integration tests, leaving individual branches, string literals, and array literals unobserved by any assertion. AgentRegistryDeps is a narrow, injectable surface built exactly for direct testing: a fake deps object with vi.fn() collaborators asserts on readIdentity/writeIdentity's composite key, registerAgent's new-vs-existing branch and visibility-gated federation broadcast, updateAgent's name/status change notifications and not-found error, listAgents' ghost-visibility filtering including self- visibility, and setAgentOffline's owner-only broadcast gating.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…utant Verified 97.56% mutation score against src/core/agent-registry.ts (40 killed, 1 survived) -- the one remaining survivor is a true equivalent, matching stale-agent-checker.test.ts's identical redundant-set pattern.
|
🎉 This PR is included in version 2.21.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #104
Test plan
pnpm typecheckpnpm lintpnpm test(60 files, 426 tests, full suite green)