test(core): direct unit tests for ConnectionApproval's admission and fallback behaviour - #122
Merged
Merged
Conversation
…our directly ConnectionApproval was previously exercised only indirectly through approval.integration.test.ts's end-to-end transport scenarios, leaving several individual branches, error messages, and fallback string literals unobserved. ConnectionApprovalDeps is a narrow, injectable surface built exactly for direct testing: a fake deps object with vi.fn() collaborators asserts on handleConnectionRequest's queued delivery event and live push, accept/reject's not-pending error messages, connectToRemote's name/fingerprint fallback when no local agent is registered yet and its fire-and-forget rejection handling, startDataServerOnly's PeerInfo recording and unref call, and listPendingConnections' entry lifecycle.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.21.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #105
Test plan
pnpm typecheckpnpm lintpnpm test(61 files, 438 tests, full suite green)