test(core): direct unit tests for PeerLifecycle's dispatch and self-connect guards - #123
Merged
Merged
Conversation
…irectly PeerLifecycle was previously exercised only indirectly through end-to-end mesh integration tests, leaving several individual branches, self-connect guards, and handleDataMessage's method-dispatch branches unobserved. A couple of the survivors Stryker reported against handleDataMessage were timeouts rather than survivors under the whole-suite command runner: emptying the method body doesn't fail fast, it hangs some unrelated integration test waiting on state that never arrives. A direct unit test that asserts on the same mutation fails immediately instead, converting a slow timeout into a fast, precise kill. PeerLifecycleDeps is a narrow, injectable surface built exactly for direct testing: a fake deps object with vi.fn() collaborators asserts on handlePeerList/handlePeerJoined's self-connect guards, handlePeerConnected's state_sync gating on non-empty agent state, handleDataMessage's method-dispatch branches, handleBecomeCoordinator's full peer-table replacement and stale-agent-checker start, and handlePeerDisconnected's peerInfo cleanup.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #108
Test plan
pnpm typecheckpnpm lintpnpm test(62 files, 449 tests, full suite green)