test(core): direct unit tests for FederationBridge's fed:-prefix and filtering logic - #124
Merged
Merged
Conversation
… directly FederationBridge was previously exercised only indirectly through end-to-end federation.integration.test.ts scenarios, leaving many individual branches, the fed:-prefix startsWith-vs-endsWith distinction, and getVisibleAgents/getFederatedRoomMemberships' filtering unobserved. FederationBridgeDeps is a narrow, injectable surface built exactly for direct testing: a fake deps object with vi.fn() collaborators asserts on onAgentVisible's fed:<id>@<harness> key and federated tag, onAgentGone's prefix-match gating (including a case that ends with but doesn't start with the prefix, to kill a startsWith-vs-endsWith mutant), onRoomMessage/ onRoomJoin/onRoomLeave's federated-room gate and shadow-member bookkeeping, and getVisibleAgents/getFederatedRoomMemberships' fed:-prefix filtering (with the same prefix-position distinction).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…valent Map.set mutants Verified against a fresh mutation run: onRoomLeave's refreshMembership call had no assertion at all, a real gap distinct from the three Map.set-after-in-place-mutation equivalents the same run also surfaced.
|
🎉 This PR is included in version 2.21.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #107
Test plan
pnpm typecheckpnpm lintpnpm test(63 files, 467 tests, full suite green)