test(core): direct unit tests for RoomMessaging's optional-field spreads and DM key derivation - #125
Merged
Merged
Conversation
…derivation directly RoomMessaging was previously exercised only indirectly through end-to-end room-send integration tests, leaving many individual branches (optional replyTo/streamingBehavior spreads, error message text, since-filtering boundaries, self-DM vs cross-DM key derivation) unobserved. RoomMessagingDeps is a narrow, injectable surface built exactly for direct testing; loadRoomTokens is mocked since RoomMessaging only ever forwards its return value opaquely, never inspecting or verifying it. A fake deps object with vi.fn() collaborators asserts on sendRoomMessage's not-found/ not-a-member/no-token error messages, replyTo/streaming-behavior optional inclusion in both the stored message and the wire params, federated-room forwarding, and per-member fan-out excluding the sender; readRoomMessages' since-omitted/since-empty/since-set filtering boundaries; and sendDm's self-DM shortcut (no recipient validation, no wire round trip, self:<id> key) versus cross-agent validation, sorted dmRoomPath key, and error messages.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…' equivalent Verified against a fresh mutation run: sendRoomMessage's own streamingBehavior inclusion on the stored message (distinct from the already-tested wire-params version) had no assertion; readRoomMessages never distinguished the real since='' shortcut from a mutant comparing against a different literal; and sendDm's cross-agent wire params never asserted streaming-behavior's absence when omitted (only presence was checked). The remaining since==='' ConditionalExpression mutant is a practical equivalent given every RoomMessage's timestamp is always a real ISO string, documented in the file header rather than forced.
Verified against a fresh mutation run: the StringLiteral mutant survives for the identical reason the ConditionalExpression mutant does (filtering with since="" reproduces the early-return's output for any real, non-empty timestamp), not a separate gap the earlier test closed. Corrected the file header to document both, and fixed an inline comment on an unrelated test that had wrongly claimed to distinguish this specific mutant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #110
Test plan
pnpm typecheckpnpm lintpnpm test(64 files, 491 tests, full suite green)