feat(core): wire this store's own rooms into the hosted-rooms gossip - #132
Merged
Merged
Conversation
MeshStore gains a hostedRooms getter, reading this store's own currently-owned public/private rooms out of the existing rooms Map in the lightweight gossip-safe shape WireMeshTransport's own readvertiseGossip tick expects. Secret rooms and rooms this store has only replicated (rather than owns) are excluded -- "hosted" means this device is the one a joiner should actually reach. bridge-mesh.ts wires it in as WireMeshTransport's getHostedRooms callback, the same construction site selfStatus already feeds getCurrentPresence through. createRoom's own room_upsert broadcast stays untouched -- this only makes the gossip-based picture available alongside it, not a replacement yet.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Mearman
added a commit
that referenced
this pull request
Sep 16, 2026
listRooms now also surfaces every public/private room this store has heard gossiped by another device (via room/hosted, #131/#132) but never joined or otherwise locally recorded, mixed into its existing Room[] result as a display-only placeholder -- id/name/type/owner/ description real, everything membership-shaped (members, memberJoins, etc.) genuinely empty, since a gossip hint is not the same as admission and this store has nothing else real to report for it. A room already known locally always wins; a gossip advert for it is silently ignored rather than shadowing the real record. MeshTransport gains an optional listKnownDevices method (matching WireMeshTransport's own already-shipped implementation) so RoomLifecycle can read it through the existing abstract requireTransport() port rather than depending on the concrete WireMeshTransport type -- absent for any transport implementation that doesn't offer it, in which case the merge step is simply a no-op, matching every construction site that predates this feature. A gossiped candidate is narrowed through a real type guard (isHostedRoomAdvert) before use, matching the codebase's own "an advert not participating in this convention is not an error" gossip-consumption pattern already established for presence/status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds MeshStore.hostedRooms, reading this store's own currently-owned public/private rooms out of the existing rooms Map in the lightweight gossip-safe shape #131's readvertiseGossip tick expects (secret rooms and merely-replicated-not-owned rooms excluded). bridge-mesh.ts wires it in as WireMeshTransport's getHostedRooms callback, the same construction site selfStatus already feeds getCurrentPresence through.
This is the remaining wiring piece #48 flagged after #130/#131 landed: the gossip mechanism now actually carries real room data end to end, not just a synthetic test fixture. createRoom's own room_upsert broadcast is untouched -- this makes the gossip-based picture available alongside it, not a replacement. Merging a gossip-discovered room into listRooms (for a peer that hasn't joined yet) is still its own separate follow-up, per #48's own note that it needs a real decision about a not-yet-joined room's synthesized shape.
Refs #48.