fix(core): name the actual mismatch when the mesh coordinator port is unusable - #146
Merged
Merged
Conversation
… unusable init() degraded to a generic "Running without mesh -- agent-comms will be unavailable" whenever becomeCoordinator failed with EADDRINUSE, with no indication of why. connectToCoordinator has always already failed by this point, so whatever holds the port isn't functioning as a reachable coordinator either -- most plausibly a stale process left over from a previous run, or a differently-versioned agent-comms instance that can't be joined. The error now says so explicitly, and still includes the underlying EADDRINUSE message for full diagnostic detail.
Mearman
marked this pull request as ready for review
September 16, 2026 06:05
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #53.
Investigated #53's own remaining scope. The "hard flag-day cutover" itself already happened -- there is no v1 code left anywhere in this repo, the package is already several major versions into v2 (currently 2.28.0), and the README's own "Breaking change (v2)" section documents it as a completed, no-migration-path cutover. That part of #53 is done.
The one concrete, still-open item #53's body actually names is the coordinator-port error message:
init()degraded to a generic "Running without mesh -- agent-comms will be unavailable" wheneverbecomeCoordinatorfailed withEADDRINUSE, with no indication of what actually went wrong.connectToCoordinatorhas always already failed by the time this path is reached, so whatever holds the port isn't functioning as a reachable coordinator either -- most plausibly a stale process left over from a previous run, or a differently-versioned agent-comms instance nothing here can join. The message now says so explicitly (naming the port, naming the two plausible causes) while still including the underlyingEADDRINUSEmessage for full diagnostic detail.Test plan
pnpm typecheckpnpm lintpnpm test(772/772)pnpm build