chore(deps-dev): bump @semantic-release/exec from 6.0.3 to 7.1.0 - #8
Closed
dependabot[bot] wants to merge 1 commit into
Closed
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/semantic-release/exec-7.1.0
branch
2 times, most recently
from
May 21, 2026 11:22
5376549 to
f7b99cc
Compare
Bumps [@semantic-release/exec](https://github.com/semantic-release/exec) from 6.0.3 to 7.1.0. - [Release notes](https://github.com/semantic-release/exec/releases) - [Commits](semantic-release/exec@v6.0.3...v7.1.0) --- updated-dependencies: - dependency-name: "@semantic-release/exec" dependency-version: 7.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/semantic-release/exec-7.1.0
branch
from
May 23, 2026 18:04
f7b99cc to
4220607
Compare
Member
|
@dependabot rebase |
Contributor
Author
|
Looks like @semantic-release/exec is up-to-date now, so this is no longer needed. |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/semantic-release/exec-7.1.0
branch
September 8, 2026 22:11
mavrikfalkon
added a commit
to mavrikfalkon/agent-comms
that referenced
this pull request
Sep 12, 2026
…rtial) Access-Control-Allow-Origin: * on handleRequest let any website open in the users browser silently fetch or POST to the local agent-comms API (list agents/rooms, read room messages, or drive any CommsAction via POST /api/action) with no origin restriction. The server only binds to 127.0.0.1, so this was never remotely exploitable, but any site open in another tab could act as the user against their own local agent. Removed the CORS headers and the OPTIONS preflight handler entirely - the one documented cross-origin use case (a PWA served from GitHub Pages, per the standalone e2e test) never calls this REST API; it only probes with a no-cors fetch and talks over /ws/mesh, neither of which needs a permissive CORS header. Same-origin requests (the normal case: loading the dashboard directly) are unaffected, since CORS headers only matter for cross-origin callers. This does not add authentication - the server is still open to anyone who can reach 127.0.0.1 on this machine with no credential. That is the harder half of bug ExaDev#8, deferred to the planned remote/phone-access work, since a real fix needs to thread a token through the frontend (api.ts, the WebSocket client, possibly the mesh worker), not just the server. Adds a regression test asserting no Access-Control-* headers are sent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mavrikfalkon
added a commit
to mavrikfalkon/agent-comms
that referenced
this pull request
Sep 12, 2026
…rrection) codex's review of 81793ca (CORS removal) found the fix incomplete: removing CORS headers only blocks a cross-origin page from READING a response, not from causing the request in the first place. A CORS-'simple' request (e.g. Content-Type: text/plain carrying a JSON body) needs no preflight, so a cross-origin page could still silently POST /api/action and mutate rooms/agents — my earlier 'this closes the act-as-you angle' claim, and the code comment saying the same, were wrong. Confirmed independently by reading the handler: it never checked Content-Type before parsing the body as JSON. Also flagged: both WS upgrade paths had no origin check at all, and /ws/mesh's is not a gap to close — mesh-client.ts intentionally opens it from other origins (the standalone-PWA/GitHub-Pages case), so an origin allowlist there would break a real feature, not fix a bug. Fixes: - /api/action now rejects any Content-Type other than application/json (415) before reading the body at all, closing the disguised-request path regardless of what a CORS preflight would have allowed. - The dashboard's own chat WS (/, not /ws/mesh) now rejects a browser-supplied Origin that doesn't match this server's own address; no Origin header (non-browser clients) is still allowed through. /ws/mesh is deliberately left open, with a comment explaining why. - Corrected the handleRequest comment, which overstated what dropping CORS actually closed. New tests assert actual rejected mutations (a disguised POST does not create the room), not just header absence: the Content-Type check, the dashboard WS origin check, and a test documenting /ws/mesh's intentional cross-origin openness so nobody 'fixes' it by accident. Verified: tsc clean, eslint clean, 13/13 in web-server.integration.test.ts (up from 8), full npm test 49/50 (same pre-existing Windows failure). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mavrikfalkon
added a commit
to mavrikfalkon/agent-comms
that referenced
this pull request
Sep 12, 2026
Three corrections from codex's source review of 2a94381: 1. Authorization comes from Butch's explicit instruction/delegation, not from an item merely appearing in bugs-found.md or a room message alone. ExaDev#7/ExaDev#8 needed his explicit override of an earlier restriction even though both were already on the list — being listed was never sufficient on its own. Once he has authorized something, though, that stands without re-asking. 2. Don't unilaterally reconstruct and commit another owner's WIP to split a tangled file — coordinate with them first and serialize the actual git operations. (I'd been doing exactly this unilaterally all night without ever asking the other author.) 3. Split 'review' into two distinct, separately-reportable things — source/diff review and independently-executed checks — instead of one 'trusting reports missed bugs twice' claim that overstated what the review record actually shows (codex's ExaDev#8 findings came from source review of code whose reported tests were passing, not from re-running a check that had been skipped). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @semantic-release/exec from 6.0.3 to 7.1.0.
Release notes
Sourced from @semantic-release/exec's releases.
... (truncated)
Commits
a285bc5feat(error): print more useful error for non-process failure (#449)aa1a2bcchore(deps): lock file maintenance (#451)b0dc7abchore(deps): update dependency ava to v6.3.0 (#450)93bf408chore(deps): lock file maintenance (#448)0e70c6fchore(deps): lock file maintenance (#446)e643dc3ci(action): update actions/setup-node action to v4.4.0 (#445)a08859echore(deps): lock file maintenance (#444)da1754echore(deps): lock file maintenance (#443)72668ccchore(deps): lock file maintenance (#442)3c6a8a9chore(deps): update dependency sinon to v20 (#441)