[pull] master from beyond-all-reason:master - #50
Merged
Merged
Conversation
Fixes #665 #666 #667 #668 and #707 and closes parent #664 Upon receipt of a `user/self` event, such as during recovery of connection, the client reconciles the client state with the server-provided source of truth. Since this can include a battle in-progress, a Rejoin feature has been added to the client as well. As a side effect, chat history is now preserved and recovered across all channels according to the appropriate ID of the source (lobby, party, user). Note that the development server, at the time of this merge, does not provide matchmaking updates in `user/self` nor the `battle/ended` event. Since this applies only to multiplayer battles and such features are still gated by dev mode, this is considered an acceptable compromise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )