fix: use author date, not committer date, for a commit's identity date - #2
Merged
Merged
Conversation
getHeadCommit() read HEAD's date with `git log --format=%cI`, the committer date. Every consumer of BuildIdentity.date treats it as when the commit was authored, but committer date changes whenever a commit is rebased onto a new position, even though its content and authorship never change. Any repo that rebase-merges its PRs -- the normal case -- ends up displaying a date that drifts from the commit's real author date, sometimes by tens of minutes. Switch to `%aI` (author date) instead, which stays fixed across a rebase. Add a test that amends a commit's committer date in isolation (the same effect a rebase has) and asserts the reported date still matches the original author date, so a regression back to committer date would be caught.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getHeadCommit() read HEAD's date with
git log --format=%cI, the committer date. Every consumer of BuildIdentity.date treats it as when the commit was authored, but committer date changes whenever a commit is rebased onto a new position, even though its content and authorship never change. Any repo that rebase-merges its PRs ends up displaying a date that drifts from the commit's real author date, sometimes by tens of minutes.Switches to
%aI(author date) instead, which stays fixed across a rebase. Adds a test that amends a commit's committer date in isolation (the same effect a rebase has) and asserts the reported date still matches the original author date.