Expose the full commit SHA on BuildIdentity - #3
Merged
Merged
Conversation
A release identity carries no commit reference at all today (its url points at a release page, not a commit), and a commit identity only ever exposes the full SHA embedded inside its permalink -- forcing a caller who needs the raw SHA (to compare two builds for identity, or to build its own link) to parse it back out of a URL. Add a `commit` field, always the full SHA of the resolved commit, to both branches.
Mearman
marked this pull request as ready for review
September 8, 2026 07:14
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release identity carries no commit reference at all today (its
urlpoints at a release page, not a commit), and a commit identity only ever exposes the full SHA embedded inside its permalink -- forcing a caller who needs the raw SHA (to compare two builds for identity, or to build its own link) to parse it back out of a URL.Adds a
commitfield, always the full git commit SHA of the resolved commit, to both branches ofBuildIdentity.resolvePredictedIdentitypropagates it unchanged. README and tests updated.