build(deps): bump @exadev/eslint-config to exact 2.12.1 - #7
Merged
Merged
Conversation
Pin the shared lint config to an exact version rather than a caret range. 2.12.1 brings the no-warning-comments and max-lines rules (2.12.0), a JSDoc/TSDoc doc-comment quality check (2.11.0), and a dependency-hygiene patch, on top of the previously pinned 2.10.4.
…g from the release-age gate Set saveExact so any future pnpm add/install writes a pinned version rather than a caret range, matching the exact pin just applied to @exadev/eslint-config. Add that package to minimumReleaseAgeExclude since ExaDev controls its release pipeline directly, so the age gate guarding against a compromised third-party maintainer doesn't apply to it. Both settings are written to pnpm-workspace.yaml, the only location pnpm 11+ reads for them, and mirrored into .npmrc as a fallback for a pnpm 10.x release predating YAML-based settings.
An unescaped > following a - reads as a TSDoc HTML-tag opener to the parser, which the tsdoc/syntax rule (newly enforced by the bumped eslint-config) flags as ambiguous. Escape it so the arrow renders as plain text without being mistaken for markup.
TSDoc requires an @PARAM block to be followed by a hyphen separating the parameter name from its description; the tsdoc/syntax rule (newly enforced by the bumped eslint-config) flags a block missing it as malformed. Add the hyphen to both tags.
…xtVersion's @PARAM tags Wrap the two remaining bare mentions of @semantic-release/commit-analyzer in backticks, matching every other reference to it in this file -- unquoted, the tsdoc/syntax rule (newly enforced by the bumped eslint-config) parses the leading @ as a malformed inline tag rather than plain text. Also add the required hyphen after each @PARAM name in predictNextVersion's doc comment.
Move the packageManager field to the latest pnpm release via corepack, which also upgrades the lockfile to pnpm 12's self-managed format (a packageManagerDependencies entry pinning pnpm's own binary alongside the project's dependencies, replacing the single-document layout pnpm 11 wrote). Lint, typecheck, test, and build all verified green under the new engine before this landed.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @exadev/eslint-config from ^2.10.4 to an exact 2.12.1 pin.
Between 2.10.4 and 2.12.1 the shared config picked up:
This repo has no Stryker suppression comments and no file over 800 lines, so those two rules land with no fallout. The JSDoc/TSDoc check did surface real, pre-existing issues in three files' doc comments, fixed here at the root cause (never suppressed):
@semantic-release/commit-analyzermention parsed as a malformed TSDoc inline tag in two places (quoted in backticks, matching every other mention of it in the same file)@paramblocks missing the hyphen TSDoc requires between the parameter name and its description>in an arrow (->) that TSDoc reads as a possible HTML tag openerAlso:
saveExact/minimumReleaseAgeExcludeto both pnpm-workspace.yaml (the pnpm 11+ location) and .npmrc (fallback for pre-10.17 pnpm), so future installs of @exadev/eslint-config default to an exact pin and skip the release-age gate for a package ExaDev itself publishes.Each of these is its own commit.