docs(readme): replace the non-null assertion in the usage example - #14
Merged
Merged
Conversation
Indexing a roster result is T | undefined under noUncheckedIndexedAccess; showing a ! assertion in the first example teaches exactly the pattern the package's own lint config bans. Look the session up by name and guard the undefined case instead.
…n exemptions vitest.config.ts enforces 100 percent statements, branches, functions, and lines: the coverage run exits non-zero below any threshold, so the CI step running it is the gate rather than a report. stryker.config.ts sets thresholds.break to 100 over src/domain and src/schemas, and CI runs the mutation suite as a required verify step alongside coverage; prepublishOnly chains the coverage gate ahead of publish. A local ESLint rule (local/no-stryker-disable, proven firing on a canary) bans mutation-exemption comments in any form, keeping the 100 percent score honest: an unkilled mutant must be killed by a test or fixed in the design, never waived by a comment.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessions[0]!— the exact assertion pattern the package's own lint config bans. Replaced with a name-based lookup and an undefined guard, matching how roster results should actually be consumed.Test plan