test: poll for the first heartbeat tick instead of a fixed sleep - #19
Merged
Merged
Conversation
The release job's prepublishOnly run failed this test on CI: it slept a fixed 120ms (6x the 20ms heartbeat interval) and checked once whether the registry's updatedAt had moved. A real setInterval carries no delivery guarantee under a busy scheduler, so a single fixed wait is a race against however loaded the runner happens to be at that instant, not against the interval itself. Polling in 20ms steps up to a 5s deadline only needs one tick to ever land, however late the runner makes it, so the test's outcome no longer depends on the runner's momentary CPU pressure.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.1.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release job's own `prepublishOnly` run failed on CI: `the heartbeat touches the registry on interval` slept a fixed 120ms (6x the 20ms heartbeat interval) then checked once whether the registry's `updatedAt` had moved, and lost that race on a loaded runner. Polling for the first tick against an overall 5s deadline removes the fixed-wait race entirely.
Test plan