fix(sea): drop windows from the release matrix, a real platform incompatibility - #20
Merged
Merged
Conversation
…patibility Both windows-latest and windows-11-arm built a working .exe and then crashed silently before printing anything at all when the smoke step ran it. Root cause is a genuine, documented Node.js limitation, not a CI misconfiguration: Node's net module has no real AF_UNIX support on Windows (nodejs/node#55979, nodejs/node#35008) — its local domain there is implemented with named pipes, which must live under \\.\pipe\, never an arbitrary filesystem path. Claude Code's own peer protocol addresses sockets by filesystem path end to end (docs/PROTOCOL.md), so CcPeer.start()'s UDS listen() call cannot succeed on Windows at all. Shipping a Windows binary would only hand users an executable that can never open its own socket. The originally approved plan for the SEA milestone scoped this matrix to darwin and linux only; win32 was added afterward without checking this — it should not have been there in the first place. Reverting to the four platforms that can actually run this software, and documenting the limitation in the README rather than leaving it to be rediscovered as a support question.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.1.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both Windows SEA legs built a working `.exe` and then crashed silently before printing anything when the smoke step ran it. Root cause is a genuine, documented Node.js limitation, not a CI bug: Node's `net` module has no real AF_UNIX support on Windows (nodejs/node#55979, nodejs/node#35008) — its local domain there is named-pipes-only, under `\.\pipe\`, never an arbitrary filesystem path. Claude Code's own peer protocol addresses sockets by filesystem path end to end, so `CcPeer.start()`'s UDS `listen()` call cannot succeed on Windows at all.
The originally approved plan scoped the SEA milestone to darwin and linux only; win32 was added afterward without checking this. Reverting to the four platforms that can actually run this software, and documenting the limitation in the README.
Test plan