fix(ci): repair the GitHub Packages mirror and SEA smoke reliability - #23
Merged
Merged
Conversation
…mirror The mirror job rewrote package.json's name and registry for the GitHub Packages scope but never its version, so pnpm publish always used whatever version happens to be committed in source (the 0.0.0 placeholder, since semantic-release's own version bump lives only in the release job's ephemeral working copy and is never committed back here). Every mirror attempt since the first has failed with "cannot publish over the previously published versions: 0.0.0". Setting version from the already-resolved release tag fixes this for good.
CcPeer.start() spawns a real subprocess on Windows (WinProcInfo's own powershell.exe) before it ever binds its listening socket, and that spawn's latency is exactly what the test suite's own REAL_PROCESS_SPAWN_TEST_TIMEOUT_MS headroom exists to accommodate. A fixed 5-second background window before checking for the startup banner does not give the packaged binary the same headroom, and a real windows-11-arm runner exceeded it. Polling up to 20 seconds, and exiting the moment the banner appears or the process itself exits, also reports a genuine crash immediately rather than only after the full wait, and dumps the captured log on failure for diagnosis.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two failures observed on the post-merge run of #21 (native Windows support), both real, pre-existing bugs unrelated to that PR's own diff:
0.0.0placeholder) —@exadev/cc-peeron GitHub Packages has only ever had0.0.0published, and every mirror attempt since has failed with "cannot publish over the previously published versions".CcPeer.start()spawns a real subprocess on Windows (WinProcInfo's ownpowershell.exe) before it ever binds, and a realwindows-11-armrunner exceeded that 5-second window. Replaced with a polled wait (up to 20s, matching the headroom already given to the equivalent real-subprocess-spawning tests) that exits immediately on either the startup banner or the process dying, and dumps the captured log on failure.