fix(test): give the SEA binary e2e test its own startup budget - #29
Merged
Merged
Conversation
macos-26-intel is the first CI run ever to actually reach this check — every earlier attempt queued forever against the since-retired macos-13 label — and it exceeded REAL_PROCESS_SPAWN_TEST_TIMEOUT_MS's 20s here. Loading and JIT-compiling one large single-file bundle with every dependency inlined is a heavier cold start than a plain CcPeer.create(), which that constant was sized for. Gives this test its own SEA_BINARY_STARTUP_TIMEOUT_MS instead of reusing a budget sized for a different, lighter kind of subprocess spawn.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sea (macos-26-intel) failed on the latest release: macos-26-intel is the first CI run ever to actually reach this check (every earlier attempt queued forever against the since-retired macos-13 label), and the packaged binary took longer than REAL_PROCESS_SPAWN_TEST_TIMEOUT_MS's 20s to start there. Loading and JIT-compiling one large single-file bundle with every dependency inlined is a heavier cold start than a plain CcPeer.create(), which that constant was sized for. Gives the e2e test its own SEA_BINARY_STARTUP_TIMEOUT_MS (60s) instead.