fix(sea): drop Intel macOS from the release matrix - #31
Merged
Merged
Conversation
…de SEA platform A real macos-26-intel runner confirmed the packaged binary SIGSEGVs within a second of starting, every time. Node's own SEA docs state plainly, under Platform Support, "macOS (arm64 only; x64 is not currently supported and is skipped in the tests)" — nodejs/node#62893 tracks the identical crash upstream, unresolved. This is a genuine gap in Node's own SEA feature for that platform, not something fixable in this repository, unlike the earlier native-Windows named-pipe work, which had a real fix available. cc-peer's regular npm package (and npx cc-peer) already works fine on Intel macOS — verify-macos (macos-26-intel) runs the real, unbundled module there — only the standalone SEA executable can't be built for it, so that job keeps the platform while sea drops it. README updated to state this precisely rather than claim every platform pair ships a binary.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.2.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sea (macos-26-intel) has failed on every release since it started getting a runner. The real cause (confirmed with diagnostics in #30): the packaged binary SIGSEGVs within a second of starting, every time. Node's own SEA docs state plainly, under Platform Support, "macOS (arm64 only; x64 is not currently supported and is skipped in the tests)" — nodejs/node#62893 tracks the identical crash upstream, unresolved. This is a gap in Node's own SEA feature, not something fixable here. cc-peer's regular npm package already works fine on Intel macOS (verify-macos (macos-26-intel) proves it); only the standalone SEA executable can't be built for that platform, so only the sea job drops it.