chore: pin eslint-config exactly and bump pinned pnpm to 12.4.1 - #39
Merged
Merged
Conversation
Keep the dependency pinned to an exact version, never a caret range.
Set saveExact in both .npmrc and pnpm-workspace.yaml (pnpm 11 moves settings out of .npmrc into the workspace file, so both are needed across pnpm 10 and 11) and carry the existing eslint-config release-age exclusion into pnpm-workspace.yaml alongside it.
Move build-script approval and dependency overrides out of package.json's now-unread pnpm field into pnpm-workspace.yaml (pnpm 12 no longer reads package.json#pnpm at all), dropping protobufjs and koffi from the allowed builds list since neither is in the dependency tree.
Mearman
marked this pull request as ready for review
September 14, 2026 09:14
Mearman
deleted the
chore/eslint-config-pin-and-package-manager-fixup
branch
September 14, 2026 09:14
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #38, which bumped @exadev/eslint-config to 2.12.0 before three new standing conventions existed for this dependency.
pnpmfield (onlyBuiltDependencies, overrides) into pnpm-workspace.yaml's allowBuilds and overrides keys, since pnpm 12 no longer reads package.json#pnpm at all. protobufjs and koffi were dropped from the allowed builds list since neither is actually in the dependency tree.Install, lint, typecheck, test, and build all pass under pnpm 12.4.1.