fix(action): define COMMENT_ID before referencing it in the progress-comment step - #59
Merged
Merged
Conversation
…comment step Under set -u, the "Post progress comment" step's own closing diagnostic line read an unset COMMENT_ID: the step only ever built comment_id inline inside the GITHUB_OUTPUT echo, never assigning it to a local variable the later echo could read. This crashed the step on every run of every mode (the step's own continue-on-error kept the job green, so the crash was silent). Assign COMMENT_ID from the API response once, then reuse it for both the output and the diagnostic line.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
❌ Claude's run did not complete (outcome: failure). View job run |
|
🗜️ Headroom context compression
|
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Post progress comment" step's closing diagnostic line reads
$COMMENT_ID, but the step never assigns that variable; it only ever built the value inline inside thecomment_id=...GITHUB_OUTPUT line. Underset -uthis fails with "COMMENT_ID: unbound variable" at the very end of the step, on every run of every mode.Introduced in e93cb45, which replaced the old
COMMENT_ID=...assignment with the inlinecomment_id=$(jq ...)output write but dropped the variable itself. Silent because the step hascontinue-on-error: true, so the crash never fails the job -- caught while triaging an unrelated PR's ownclaude-reviewdogfooding check.Fix: assign
COMMENT_IDonce from the API response, reuse it for both the output and the diagnostic echo.