feat: allow @ in the body of identity and profile names - #15
Merged
Merged
Conversation
Mearman
marked this pull request as ready for review
September 11, 2026 07:58
Member
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Mearman
force-pushed
the
validate-identity-name-before-wizard
branch
from
September 11, 2026 07:58
e418ca4 to
d4b1ff6
Compare
Base automatically changed from
validate-identity-name-before-wizard
to
main
September 11, 2026 08:07
An email address now names its own identity directly: claude-use @joseph.mearman@exadev.io works end to end, because the @<name> selector already splits its token at the first @ only. The first character stays strictly alphanumeric, so a leading @ is still rejected and that first-@ split stays unambiguous. PROFILE_NAME_RE widens in lockstep rather than by coincidence: the identity wizard offers the identity's own name as the default configuration-profile name, so an email-shaped identity would otherwise suggest a profile name its own validator rejects. The InvalidIdentityNameError message and the generated schema/Identity.schema.json pattern update with it.
Mearman
force-pushed
the
allow-at-in-identity-name-body
branch
from
September 11, 2026 08:10
7be15f3 to
03a6d06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An email address now names its own identity directly:
claude-use @joseph.mearman@exadev.ioworks end to end, because the@<name>selector already splits its token at the first@only.IdentitySchema.nameallows@in the body; the first character stays strictly alphanumeric, so a leading@is still rejected and the selector's first-@split stays unambiguous.PROFILE_NAME_RE(the profile wizard's validator) widens in lockstep rather than by coincidence:runIdentityWizardoffers the identity's own name as the default configuration-profile name, so an email-shaped identity would otherwise suggest a profile name its own validator rejects.InvalidIdentityNameError's message and the generatedschema/Identity.schema.jsonpattern update with it.Stacked on #14 (the wizard pre-validation that makes an invalid name fail before any prompt); its
@exadevtest example pins the leading-@boundary this change leaves in place.