Default the new-identity wizard's profile prompt to skip - #20
Merged
Merged
Conversation
A bare Enter on "Create a default configuration profile for <name>?" picked "create", since a select prompt with no explicit initial value defaults to whichever option is listed first. Most identities need no profile of their own at all — they're meant to fall through to whatever the global default (or a directory rule) already resolves to, and a profile only earns its keep once an identity genuinely needs to diverge from that. Defaulting to "create" nudged every new identity toward its own profile regardless. SelectParams gains an initialValue field, threaded straight into @clack/prompts' own select(), which already supports it — this moves the default answer without reordering the options themselves, so "skip" becomes what Enter confirms without becoming the first, most prominent line on screen. The wizard's own prompt sets it to "skip".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Create a default configuration profile for ""?" defaulted to "create" on a bare Enter, since a select prompt with no explicit initial value falls back to whichever option is listed first. Most identities don't need a profile of their own — they're meant to fall through to the global default (or a directory rule), and a profile only earns its keep once one genuinely needs to diverge from that.
SelectParamsgains aninitialValuefield, threaded into@clack/prompts' ownselect()(which already supports it). This moves the default answer without reordering the options — "skip" becomes what Enter confirms, without becoming the first line on screen ahead of "Create and configure a profile". The wizard's prompt sets it to"skip".