fix: preserve literal -- when forwarding args in claude-use run - #23
Merged
Merged
Conversation
Commander's variadic [args...] argument on the run subcommand strips a literal -- from the forwarded argv by default, treating it purely as its own end-of-options marker rather than a token to pass through. A command like `claude mcp add name -- npx -y pkg` therefore reached the real claude binary as `mcp add name npx -y pkg`, with no -- left to shield -y from claude's own option parser, which then rejected it as an unknown option. Add passThroughOptions() so every token after the first is forwarded verbatim, -- included. Extract the run subcommand's registration into its own runCommand.ts module, matching the register*Command pattern every other subcommand already uses, so this parsing behaviour is unit-testable without importing cli.ts itself, which runs the real CLI as a top-level side effect on import.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[args...]argument on therunsubcommand strips a literal--from the forwarded argv, treating it as an end-of-options marker rather than a token to preserve. A command likeclaude mcp add name -- npx -y pkgreached the realclaudebinary asmcp add name npx -y pkg, with no--left to shield-y, which the real binary's own Commander parser then rejected as an unknown option.passThroughOptions()to therunsubcommand so every token after the first is forwarded verbatim,--included.runsubcommand's registration into its ownsrc/runCommand.tsmodule, matching theregister*Commandpattern every other subcommand (identity,profile,rules,check,configure,doctor,shim) already uses, so this parsing behaviour is unit-testable in isolation without importingcli.tsitself (which runs the real CLI as a top-level side effect on import).Test plan
pnpm test— 807/807 passing, including 3 new regression tests insrc/runCommand.test.tscovering: a literal--preserved, a flag with no--forwarded unchanged, and an empty args listpnpm typecheckpnpm lint