fix(release): push over SSH via repositoryUrl, not a git config rewrite - #11
Merged
Merged
Conversation
semantic-release builds its release-commit/tag push URL from the resolved repositoryUrl, embedding an x-access-token:$GITHUB_TOKEN@ credential whenever that URL is https:// -- it never reads or respects the ambient git remote or any url.insteadOf rewrite for this purpose. The previous fix's global insteadOf mapping targeted a plain https://github.com/ prefix, but the actual push URL already had a token embedded before that prefix, so the rewrite never matched and the push kept failing identically. Setting repositoryUrl to the SSH form in release.config.ts (separate from package.json's own git+https:// repository field, which is public consumer metadata and stays as-is) skips the token-embedding path entirely, so the push authenticates with whatever key actions/checkout's ssh-key input already wired into core.sshCommand -- the deploy key registered as a DeployKey bypass actor on the ruleset.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10, which still failed identically. Fetched @semantic-release/git's actual source: it pushes whatever origin string it's given verbatim, and semantic-release core is the layer that embeds an https://x-access-token:$GITHUB_TOKEN@github.com/... credential into the push URL whenever the resolved repositoryUrl is https://. #10's global git config url.insteadOf rewrite targeted a plain https://github.com/ prefix, but the actual push URL already had the token embedded before that prefix, so it never matched.
Setting repositoryUrl explicitly to the SSH form in release.config.ts skips that token-embedding path entirely (package.json's own repository field, public metadata, stays https://). The push then authenticates over SSH using the deploy key actions/checkout's ssh-key input already wires into core.sshCommand, and GitHub attributes it to the DeployKey bypass actor on the ruleset.