Skip to content

feat: ban Stryker suppression comments and enforce an 800-line file limit - #12

Merged
Mearman merged 1 commit into
mainfrom
feat/ban-stryker-disable-and-max-lines
Sep 14, 2026
Merged

Mearman merged 1 commit into
mainfrom
feat/ban-stryker-disable-and-max-lines

Conversation

@Mearman

@Mearman Mearman commented Sep 14, 2026

Copy link
Copy Markdown
Member

Adds two rules to the default (type-checked) ruleset in `recommended-type-checked.ts`:

  • `no-warning-comments` bans any `Stryker disable`/`Stryker disable next-line` comment (case-insensitive, anywhere in the comment). ESLint's own `noInlineConfig` only knows about `eslint-disable` comments, so a Stryker mutation-testing suppression comment was otherwise invisible to lint.
  • `max-lines` caps a file at 800 real lines of code (`skipBlankLines`/`skipComments` both true, so blank lines and WHY-explanation comments don't count against the limit).

Both are added unconditionally (not relaxed for test files), with new `recommended-type-checked.test.ts` coverage and a README update documenting them alongside the rest of the default export's tuned rules.

…imit

no-warning-comments flags any Stryker disable/disable-next-line comment,
since ESLint's own noInlineConfig has no awareness of Stryker's separate
comment syntax and can't otherwise catch mutation-testing coverage being
silently suppressed. max-lines caps a file at 800 real lines of code,
skipping blank lines and comments so WHY-explanations don't count against it.
@Mearman
Mearman marked this pull request as ready for review September 14, 2026 03:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-09-14T03:47:14.653231Z 5dc2b25 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Mearman
Mearman merged commit a09c74f into main Sep 14, 2026
6 checks passed
@Mearman
Mearman deleted the feat/ban-stryker-disable-and-max-lines branch September 14, 2026 03:45
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant