chore: dogfood defineConfig() now that exadevConfig() satisfies it - #5
Merged
Conversation
The plain-array export in this file existed specifically to route around the cross-package type gap #4 just fixed (exadevConfig() was typed against typescript-eslint's own Config, not @eslint/core's ConfigObject). Now that exadevConfig() satisfies defineConfig() directly, use it here too -- this file is the first real, live proof that consumers get real config validation and extends support from defineConfig() rather than routing around it.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.10.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4. The plain-array export in this file's
eslint.config.tsexisted specifically to route around the cross-package type gap #4 fixed. Now thatexadevConfig()/defaultConfigare typed against@eslint/core'sConfigObject, they satisfydefineConfig()directly -- use it here too, as the first real, live proof consumers get real config validation andextendssupport rather than routing around it.Test plan
pnpm typecheckcleanpnpm lintcleanpnpm test-- 347/347 passingpnpm build+attw --pack-- no problems found