chore: bump @exadev/eslint-config to 2.12.1, pin pnpm 12.4.1 - #2
Merged
Merged
Conversation
Pins the shared lint config to an exact version rather than a caret range so a fresh install can't silently pick up a newer major/minor without review. 2.12.1 adds no-warning-comments (bans "Stryker disable" suppression comments) and max-lines (caps a file at 800 lines of code), plus a JSDoc/TSDoc quality rule from 2.11.0 -- none of which flag anything in this repo's existing source.
….17 pnpm fallback Sets saveExact in pnpm-workspace.yaml (the setting pnpm 11+ actually reads; project .npmrc is registry/auth-only from pnpm 11 onward) so a future `pnpm add` defaults to an exact pin without needing the flag spelled out each time. Adds a matching .npmrc entry purely as a fallback for a pnpm 10.x release older than 10.17, where the YAML settings block doesn't exist yet -- inert on the pnpm version this repo actually runs. @exadev/eslint-config itself is already covered by the existing minimumReleaseAgeExclude glob for '@exadev/*' in pnpm-workspace.yaml, so no change was needed there; the .npmrc fallback still names it explicitly since that file has no equivalent existing glob to fall back on.
Regenerates the lockfile for the pnpm 12 engine via corepack so the repo's own packageManager pin matches a current pnpm release rather than a fixed 11.x. Install, lint, typecheck, test, and build all pass unchanged under the new engine.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @exadev/eslint-config from ^2.10.6 to an exact 2.12.1 pin, adds saveExact/minimumReleaseAgeExclude defaults for future adds, and bumps the repo's own pinned package manager to pnpm 12.4.1.
2.12.1 brought no-warning-comments (bans "Stryker disable" suppression comments), max-lines (800-line cap per file), and a JSDoc/TSDoc quality rule from 2.11.0. None of them flag anything in this repo's existing source -- lint, typecheck, test, and build all pass unchanged under the new config and under the new pnpm engine.
@exadev/eslint-configis already covered by the existingminimumReleaseAgeExclude: ['@exadev/*']glob in pnpm-workspace.yaml, so onlysaveExact: trueneeded adding there;.npmrcgets both settings as a fallback for pre-10.17 pnpm 10.x, though this repo runs pnpm 12 so it's inert here.