chore: bump @exadev/eslint-config to 2.12.1 - #45
Merged
Merged
Conversation
Bumps the shared ESLint config from the ^2.10.2 range to an exact 2.12.1 in the root package.json and in trilean, trilean-regex, and trilean-sql, each pinned independently. 2.12.1 brings JSDoc/TSDoc comment-quality validation, a ban on Stryker-suppression comments, and an 800-real-line-per-file cap, none of which change any existing runtime behaviour on their own.
Sets saveExact: true in pnpm-workspace.yaml, the settings location pnpm 11+ actually reads (.npmrc is registry/auth-only there), so every future pnpm add lands as an exact version by default rather than a caret range -- matching the exact pin @exadev/eslint-config and @exadev/semantic-release-workspace already carry. Adds the equivalent save-exact/minimum-release-age-exclude lines to .npmrc as a fallback for a pnpm 10.x release older than 10.17, which predates pnpm-workspace.yaml's own settings block.
…comment TSDoc's parser treats a bare @word as an attempted block tag even mid-sentence, so "@exadev/semantic-release-workspace" and "@semantic-release/git" in this comment's prose were each read as a malformed tag rather than plain text. Wrapping both in backticks marks them as code spans, which TSDoc skips over during tag parsing.
TSDoc has no bracketed-type syntax for @throws -- writing `@throws {RegexParseError} ...` makes the parser expect an inline tag starting with "{@" and fail on the bare "{". Backticking the type name instead reads as an ordinary code span, which is what these comments already do for every other inline type reference.
…it as HTML A bare > after a hyphen (an ASCII "->" arrow) reads to TSDoc as the start of an HTML closing tag, which it flags as needing escape. Backslash-escaping each > lets these comments keep using "->" as a mapping/traversal arrow without tripping the parser.
…r the 800-line cap evaluator.test.ts had grown to 3152 lines of real code, well over the new max-lines cap. Splits it by tested concern into nine files (literal/reference values, temporal arithmetic, real-number arithmetic, complex-number arithmetic, compare/textCompare, memberOf/exists/quantifiers, lookup/fold/accumulator, conditional/delegate/treeReference/call, and the resource-limit and golden-example integration checks), each comfortably under the cap. Extracts the shared default resolver, expectDefinite/expectIndeterminate assertion helpers, and the isPlainRecord/isUnknownArray type guards -- previously duplicated near-verbatim in evaluator.indeterminacy.test.ts -- into a new evaluator-test-helpers.ts every split file imports from.
…line cap
evaluator.indeterminacy.test.ts had grown to 1138 lines of real code,
over the new max-lines cap. Its own structure already separated
cleanly into a fixture-driven reference table (one row per
node-kind x reason-code combination) and a set of explicitly
called-out edge cases beyond that table, so it splits along that same
seam into evaluator.indeterminacy-table.test.ts and
evaluator.indeterminacy-cases.test.ts. Extracts the fixture machinery
both files share (baseResolvers, the shared node fragments, the
pred/expr/runFixture helpers) into evaluator-indeterminacy-helpers.ts.
Also fixes the one real new-rule violation this uncovered: runFixture
narrowed an indeterminate result's reason via `result as { reason:
IndeterminateReason }`, banned outright by this project's own
no-assertions rule (allowed in *.test.ts files specifically, which
this shared helper module no longer is). Typing Fixture.run's result
as a proper `FixtureRunResult` discriminated union, rather than the
looser `{ status: string }` it replaces, lets runFixture narrow
result.reason directly with no assertion needed.
…y logic into dedicated modules evaluator.ts had grown to 1564 lines of real code, over the new 800-line cap. Splits it into four cohesive pieces along its own existing seams: evaluator-operations.ts holds the pure, non-recursive three-valued combination/comparison/arithmetic helpers (combineAnd, compareValues, applyArithmetic and their siblings); evaluator-budget.ts holds the per-call resource-limit infrastructure (EvaluationBudget and its constants); evaluator-collection.ts holds some/every/fold's shared collection-resolution logic, decoupled from evaluatePredicateInternal via an injected EvaluatePredicate callback rather than a direct import, which is what lets it live in its own module without recreating the circular-import hazard evaluator.ts's own top comment already documents for its two mutually-recursive core functions; evaluator-factory.ts holds createEvaluator and the default evaluatePredicate/evaluateValue pair, since that factory only ever calls into evaluator.ts and never the reverse. evaluator.ts itself now holds only evaluatePredicateInternal and evaluateValueInternal, the one part of the original file that genuinely cannot be split further without breaking their mutual recursion across a module boundary. Every caller of createEvaluator/evaluatePredicate/evaluateValue now imports from evaluator-factory.ts instead of evaluator.ts.
Runs corepack use pnpm@12.4.1 to update the packageManager field and regenerate the lockfile's packageManagerDependencies entries for the new engine. lint, typecheck, test (unit/integration/smoke/workers), and build all still pass unchanged under the new version.
Mearman
marked this pull request as ready for review
September 14, 2026 09:27
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@exadev/eslint-configfrom^2.10.2to an exact2.12.1across the workspace root and all three packages, and adds the config this repo needs going forward (saveExact, aminimumReleaseAgeExcludeentry that already covered it,.npmrcfallback). Also bumps the pinned package manager from pnpm 11.6.0 to 12.4.1.2.12.1 brings JSDoc/TSDoc comment-quality validation, a ban on Stryker-suppression comments, and an 800-real-line-per-file cap. The comment-validation rule surfaced several genuine doc-comment syntax issues (package names and arrow notation TSDoc misreads as tags/HTML,
@throws {Type}using JSDoc syntax TSDoc doesn't support) — all fixed at the syntax level, nothing suppressed. The line-count rule flagged three files:evaluator.ts(1564 real lines) and its two companion test files,evaluator.test.ts(3152) andevaluator.indeterminacy.test.ts(1138). All three are split along their own existing internal seams into focused modules/files, each comfortably under the cap — see individual commits for the reasoning behind each split, including how the collection-resolution logic was decoupled via dependency injection specifically to avoid recreating a circular-import hazard the original file's own comments already documented.No
no-warning-comments(Stryker-suppression) hits — this repo has none.Test plan
pnpm lintclean across all three packagespnpm typecheckclean (includingattw --pack)pnpm test,test:integration,test:smoke,test:workersall green (unchanged pass counts throughout)pnpm buildclean