feat(core): expose canGrant as a queryable narrowing check - #104
Merged
Conversation
mintCapabilityToken already enforced every one of tokens.cddl's own delegation-narrowing rules (bearer match, expiry within parent, scope narrows, same capability, delegations-remaining strictly less than parent's), but only as a side effect of actually attempting a mint. Extracts that arithmetic into checkNarrowing, shared by mintCapabilityToken and a new canGrant(heldToken, deviceId, candidate, now) pure query, so a caller can ask whether a delegation would succeed without attempting (and potentially failing) a real mint, and the two can never silently drift into different ideas of what narrows a token. canGrant's signature extends the issue's own originally-sketched (heldToken, capability, scope) to also take the querying device-id (needed for the bearer-match check mint itself performs) and now (needed to reject an already-expired candidate the same way mint's own first check does) -- both genuinely required for the query to agree with what a real mint attempt would actually decide, not optional extras.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mintCapabilityToken already enforced every one of tokens.cddl's own delegation-narrowing rules (bearer match, expiry within parent, scope narrows, same capability, delegations-remaining strictly less than parent's), but only as a side effect of actually attempting a mint. Extracts that arithmetic into checkNarrowing, shared by mintCapabilityToken and a new canGrant(heldToken, deviceId, candidate, now) pure query, so a caller can ask whether a delegation would succeed without attempting (and potentially failing) a real mint, and the two can never silently drift into different ideas of what narrows a token.
canGrant's signature extends the issue's own originally-sketched (heldToken, capability, scope) to also take the querying device-id (needed for the bearer-match check mint itself performs) and now (needed to reject an already-expired candidate the same way mint's own first check does) -- both genuinely required for the query to agree with what a real mint attempt would actually decide, not optional extras.
Closes #79.