docs(core): document root-minting authority as separate from delegationsRemaining - #106
Merged
Merged
Conversation
…onsRemaining delegationsRemaining: 0 correctly forbids a token from being re-delegated (it cannot be used as a parent at all), but that has never bounded the issuer's own separate, ordinary authority to mint additional independent root-level grants (no parent named) for other bearers -- there was simply no comment saying so, which is exactly how ExaDev/agent-comms PR #72 arrived at the correct pattern (each room member's own grant minted as its own independent root-level token) as an implementation-time discovery rather than a documented, intentional design. Adds a regression test locking in the pattern: a second, independent root-level grant for a different bearer succeeds even though an earlier root grant from the same issuer has delegationsRemaining: 0, since it names no parent and so has nothing to be checked against.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delegationsRemaining: 0 correctly forbids a token from being re-delegated (it cannot be used as a parent at all), but that has never bounded the issuer's own separate, ordinary authority to mint additional independent root-level grants (no parent named) for other bearers -- there was simply no comment saying so, which is exactly how ExaDev/agent-comms PR #72 arrived at the correct pattern (each room member's own grant minted as its own independent root-level token) as an implementation-time discovery rather than a documented, intentional design.
Adds a regression test locking in the pattern: a second, independent root-level grant for a different bearer succeeds even though an earlier root grant from the same issuer has delegationsRemaining: 0, since it names no parent and so has nothing to be checked against.
Closes #86.